Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Supported Python/Django Versions #3421

Merged
merged 9 commits into from Sep 22, 2015

Conversation

carltongibson
Copy link
Collaborator

@carltongibson carltongibson commented Sep 21, 2015

Fixes #3408

  • Drop Python 3.2 and 3.3 against Django master
  • Add Python 3.5 against Django master
  • Drop Django 1.5
  • Remove Django 1.5 related code from compat.py
  • Adjust README and Release Notes

Thinking to stick there and look at Python 2.6 and Django 1.6 separately

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 21, 2015

Travis is not yet supporting Python 3.5 with Tox.

Example build failure

Half inclined to just leave it in, so it comes online when they do.

@tomchristie
Copy link
Member

tomchristie commented Sep 21, 2015

How about a (possibly informal) policy of:

  • Track 4 django versions.
  • Track whichever python versions they support.

?

(Which'd be in line with this PR)

@tomchristie
Copy link
Member

tomchristie commented Sep 21, 2015

I see compat changes here - should the last checklist item also be ticked?

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 21, 2015

I'm not finished — will tick and ping when it's ready

On Mon, Sep 21, 2015 at 5:14 PM, Tom Christie notifications@github.com
wrote:

I see compat changes here - should the last checklist item also be ticked?

Reply to this email directly or view it on GitHub:
#3421 (comment)

@tomchristie
Copy link
Member

tomchristie commented Sep 21, 2015

Gotcha

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 21, 2015

How about a (possibly informal) policy of...

@tomchristie If that's the decision then OK, but I still think we should drop 1.6 and then when 1.4 goes EOL we (formally) follow Django's supported versions.

I worry that by supporting 1.6 we'd be saying it's OK to be using it — and it really isn't. (If people are stuck on 1.6 then the old versions of DRF will still work for them, and their priority should be on upgrading Django — not keeping up with us.)

(Again, "Opinion")

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 21, 2015

@tomchristie @xordoquy — This should be ready to review.

I didn't Milestone it.

The bit I wasn't sure about was compat.set_rollback. There's a mention of >=1.6 there but it was nested inside a couple of conditionals (for which I'd need to look into it...) — I left it as was.

@tomchristie
Copy link
Member

tomchristie commented Sep 22, 2015

I still think we should drop 1.6 and then when 1.4 goes EOL we (formally) follow Django's supported versions.

Def a reasonable possibility.

@tomchristie tomchristie added this to the 3.3.0 Release milestone Sep 22, 2015
tomchristie added a commit that referenced this pull request Sep 22, 2015
@tomchristie tomchristie merged commit 5b2b675 into encode:version-3.3 Sep 22, 2015
1 check passed
@tomchristie
Copy link
Member

tomchristie commented Sep 22, 2015

Okay great. We'll add django1.9-alpha when it comes out in a few days.
Dropping 1.6 also a possibility, but to be reviewed/considered separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants