Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Django 1.6 (and Python 2.6) Support #3429

Closed

Conversation

carltongibson
Copy link
Collaborator

@carltongibson carltongibson commented Sep 22, 2015

Django 1.6 is out of extended support — it is no longer receiving even security patches — it should not be used.

We should drop support too:

  • Helps with the maintenance burden for DRF
  • Doesn't give implicit blessing to keep using Django 1.6

Todo:

  • Remove Django 1.6 and Python 2.6 from text matrix
  • Remove 1.6 related code from compat.py
  • Adjust README and Release Notes.

Once we get here (and 1.4 is EOL) we could/should adopt a policy of following Django's current "extended support" versions.

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 22, 2015

@tomchristie @xordoquy — Guys, if you can spare a moment, can I get a sanity check on ResolveModelWithPatchedDjangoTests please?

  1. Here in setUp we monkey patch get_model. (OK)
  2. In tearDown the comment says "Revert monkey patching" but assigns the stored reference to a different attribute path.

This looks like an error to me. Can you advise?

Thanks!

* Corrects presumed logic error in `ResolveModelWithPatchedDjangoTests`
@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 22, 2015

See 6e86a53 — I've corrected the logic, on the assumption it was an error.

@tomchristie
Copy link
Member

tomchristie commented Sep 22, 2015

Don't understand - all lines that reference it use rest_framework.utils.model_meta.models.get_model right?

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 22, 2015

No. There's an extra .models. in tearDown

Pre-change setUp:

 rest_framework.utils.model_meta.get_model

Pre-change tearDown:

 rest_framework.utils.model_meta.models.get_model

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 22, 2015

OK. This is ready to review.

Just an aside: serializers.py is pulling OrderedDict in from fields.py via the * import. Not really an issue but confused me for a bit.

@jpadilla
Copy link
Member

jpadilla commented Sep 24, 2015

This looks good to me. Thanks for putting this together @carltongibson!

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 24, 2015

@jpadilla No probs — just a bit of yak shaving from #3404. You should merge it whilst @tomchristie isn't looking 😈

@tomchristie
Copy link
Member

tomchristie commented Sep 24, 2015

😨

@tomchristie
Copy link
Member

tomchristie commented Sep 24, 2015

He's right, tho'

@xordoquy
Copy link
Collaborator

xordoquy commented Sep 24, 2015

👀

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 28, 2015

Are we going to have this? (Can rebase if so)

@tomchristie
Copy link
Member

tomchristie commented Sep 28, 2015

Rebased. Superseeded by #3429.

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 28, 2015

Confused. This is #3429

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 28, 2015

Ah, now I see it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants