Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializers with many=True should return empty list rather than empty dict #3476

Closed
wants to merge 1 commit into from
Closed

Conversation

jpadilla
Copy link
Member

@jpadilla jpadilla commented Oct 6, 2015

Follow up proposal fix for #3434 and #3437

@jpadilla
Copy link
Member Author

jpadilla commented Oct 21, 2015

@tomchristie this is ready for a review

def errors(self):
ret = super(ListSerializer, self).errors

if ret == {}:
Copy link
Collaborator

@xordoquy xordoquy Jan 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be ret == {} and self.many ?

@xordoquy
Copy link
Collaborator

xordoquy commented Jan 19, 2016

I think I need to dig a bit why we get a dictionary in the first place. Feels like the root cause isn't fixed with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants