Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the to_field on ForeignKey fields #3526

Merged
merged 1 commit into from Oct 21, 2015
Merged

Added support for the to_field on ForeignKey fields #3526

merged 1 commit into from Oct 21, 2015

Conversation

likeon
Copy link
Contributor

@likeon likeon commented Oct 21, 2015

Closes #2426.

Rebased copy of PR #2435 which is abandoned by the author

# see also ForeignKey and ForeignObject in
# https://docs.djangoproject.com/en/1.7/_modules/django/db/models/fields/related/

if django.VERSION >= (1, 6):
Copy link
Member

@tomchristie tomchristie Oct 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the minimum supported version in master, so oughta be able to drop the compat bit.

@likeon
Copy link
Contributor Author

likeon commented Oct 21, 2015

@jpadilla Done

@jpadilla
Copy link
Member

jpadilla commented Oct 21, 2015

@tomchristie if you have no further feedback, I think this is good to go.

@tomchristie
Copy link
Member

tomchristie commented Oct 21, 2015

Great work, yup!

tomchristie added a commit that referenced this pull request Oct 21, 2015
Added support for the to_field on ForeignKey fields
@tomchristie tomchristie merged commit 58faebc into encode:master Oct 21, 2015
3 checks passed
@likeon likeon deleted the fk-to_field branch Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants