Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map all supported FilePathField options #3536

Merged
merged 3 commits into from Oct 23, 2015
Merged

Map all supported FilePathField options #3536

merged 3 commits into from Oct 23, 2015

Conversation

jpadilla
Copy link
Member

@jpadilla jpadilla commented Oct 23, 2015

Related to #3520

@jpadilla jpadilla self-assigned this Oct 23, 2015
'recursive': model_field.recursive,
'allow_files': model_field.allow_files,
'allow_folders': model_field.allow_folders
})
Copy link
Member

@tomchristie tomchristie Oct 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to exclude any of these if they have the default? (Partly for the purposes of a simple serializer repr)

Copy link
Member Author

@jpadilla jpadilla Oct 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomchristie oh yeah agree

@jpadilla
Copy link
Member Author

jpadilla commented Oct 23, 2015

@tomchristie done.

@tomchristie tomchristie added this to the 3.3.0 Release milestone Oct 23, 2015
tomchristie added a commit that referenced this pull request Oct 23, 2015
Map all supported FilePathField options
@tomchristie tomchristie merged commit 9a78db2 into encode:master Oct 23, 2015
3 checks passed
@tomchristie
Copy link
Member

tomchristie commented Oct 23, 2015

Grand - thanks as ever @jpadilla!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants