Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for multiple values for search filter #3541

Closed
wants to merge 1 commit into from

Conversation

MichalMazurek
Copy link

@MichalMazurek MichalMazurek commented Oct 23, 2015

This PR adds support for multiple search params, instead of just one.

/api/v1/model?search=first&search=last

With current master, this will create a query only for the last parameter. You could add more params using space or ','. I think it's better to use the fact that we can specify more values for one param instead of using space or commas, especially when we would like to search using those characters.

I've left backward compatibility for just one parameter given to split across spaces or commas, but I would remove this out in the future.

What do you think guys?

All the best,
Michal

@tomchristie
Copy link
Member

tomchristie commented Oct 27, 2015

Most likely we're going to want to stay with the simplest possible implementation, but I'm likely to be reviewing the filter classes with 3.4, since 3.3 introduces a bunch of nice "include this in the browsable API" functionality that it'd be good to make some more extensive use of.

@xordoquy xordoquy added this to the 3.4.0 Release milestone Nov 10, 2015
@tomchristie
Copy link
Member

tomchristie commented Jun 14, 2016

On re-review, would rather see any new functionality for SearchFilter to be made as a third party package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants