Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression causing raw data form to not display #3600

Merged
merged 1 commit into from Nov 13, 2015

Conversation

nfletton
Copy link
Contributor

@nfletton nfletton commented Nov 4, 2015

34eb18b introduced #3578 that causes raw data form to not display when there is no html form tab.

This change reverts a specific change in the referred to commit that changed the logic of when to show the HTML and|or Raw Data POST forms as tabs in the API browser.

The correct logic is to show the Raw Data form as a tab if there is also an HTML form to render (i.e. there's two tabs in total). Otherwise display the Raw Data form as an unstyled div.

The faulty logic attempted to show the the Raw Data form as a tab whether or not there was a second tab containing the HTML form. As a result of Bootstrap's default styling on tab-pane (display: none), the raw data form would not be displayed.

See #3578 for screenshots.

@tomchristie
Copy link
Member

tomchristie commented Nov 9, 2015

I think this looks right - any chance you could add a screenshot and just round out the description a little?

@nfletton
Copy link
Contributor Author

nfletton commented Nov 9, 2015

@tomchristie Added some detail to clarify

@xordoquy
Copy link
Collaborator

xordoquy commented Nov 13, 2015

Thanks for the PR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants