Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort response headers in api renderer #3655

Merged
merged 1 commit into from Nov 18, 2015

Conversation

andreif
Copy link
Contributor

@andreif andreif commented Nov 18, 2015

...to keep the same order instead of some random order.

Every app reload they jump around which may be distracting.

@tomchristie
Copy link
Member

tomchristie commented Nov 18, 2015

Okay. Odd that I've never noticed this before. Seems reasonable enough.
Care to ads screenshot before/afters against this issue just for sanities sake?

Anyone else have an objection to this?

@tomchristie tomchristie added this to the 3.3.2 Release milestone Nov 18, 2015
@andreif
Copy link
Contributor Author

andreif commented Nov 18, 2015

It happens when one modifies e.g. models.py and reloads api page. Hold on, I can make you a movie

@andreif
Copy link
Contributor Author

andreif commented Nov 18, 2015

@andreif
Copy link
Contributor Author

andreif commented Nov 18, 2015

@tomchristie done.

@jpadilla
Copy link
Member

jpadilla commented Nov 18, 2015

Yup, I've noticed this as well.
On Wed, Nov 18, 2015 at 1:23 PM Andrei Fokau notifications@github.com
wrote:

@tomchristie https://github.com/tomchristie done.


Reply to this email directly or view it on GitHub
#3655 (comment)
.

tomchristie added a commit that referenced this pull request Nov 18, 2015
Sort response headers in api renderer
@tomchristie tomchristie merged commit 378b7b8 into encode:master Nov 18, 2015
3 checks passed
@tomchristie
Copy link
Member

tomchristie commented Nov 18, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants