Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3228 - add confirm modal for delete #3662

Merged
merged 1 commit into from Dec 1, 2015
Merged

#3228 - add confirm modal for delete #3662

merged 1 commit into from Dec 1, 2015

Conversation

awwester
Copy link
Contributor

@awwester awwester commented Nov 22, 2015

Added a modal to confirm deletion of data

@jpadilla
Copy link
Member

jpadilla commented Nov 22, 2015

@awwester this is great! Mind putting together a screenshot or gif? Might also be a good idea to wrap new strings in a {% trans %} template tag`.

@jpadilla jpadilla added this to the 3.3.2 Release milestone Nov 22, 2015
@awwester
Copy link
Contributor Author

awwester commented Nov 22, 2015

drf_confirm_delete

This is my first time working with translations and although the code seems correct comparing with other instances, I'm having issues getting a positive test to be sure. I've added a couple settings according to http://www.django-rest-framework.org/topics/internationalization/#enabling-internationalized-apis but can't get my app to switch into spanish for testing.

  # settings.py
  MIDDLEWARE_CLASSES = (
    'django.middleware.locale.LocaleMiddleware',
    ...
  )
  LANGUAGE_CODE = 'es-es'

is there something I'm missing?

@jpadilla
Copy link
Member

jpadilla commented Dec 1, 2015

@awwester sorry for the delay. To move this forward faster, I'd say forget about adding translation tags, drop the django.po. After that this is good to merge.

@awwester
Copy link
Contributor Author

awwester commented Dec 1, 2015

@jpadilla The trans changes have been reverted

@jpadilla
Copy link
Member

jpadilla commented Dec 1, 2015

@tomchristie @xordoquy any feedback? If it looks good, I'm merging.

@tomchristie
Copy link
Member

tomchristie commented Dec 1, 2015

No objection from me.

jpadilla added a commit that referenced this issue Dec 1, 2015
@jpadilla jpadilla merged commit d2f90fd into encode:master Dec 1, 2015
3 checks passed
@jpadilla
Copy link
Member

jpadilla commented Dec 1, 2015

@awwester thanks again 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants