Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3628 by implementing __getnewargs__() #3701

Merged
merged 6 commits into from Dec 7, 2015
Merged

Conversation

lsanpablo
Copy link
Contributor

@lsanpablo lsanpablo commented Dec 4, 2015

No description provided.

@xordoquy
Copy link
Collaborator

xordoquy commented Dec 4, 2015

wooot, thanks !!
Looks good at first sight. Will review that a bit further today.

@xordoquy xordoquy self-assigned this Dec 4, 2015
@xordoquy xordoquy added this to the 3.3.2 Release milestone Dec 4, 2015
@xordoquy xordoquy added the Bug label Dec 4, 2015
@jpadilla
Copy link
Member

jpadilla commented Dec 4, 2015

Just wanted to link to where __getnewargs__ is mentioned. That pickle protocol is a bit odd.

@glynjackson
Copy link

glynjackson commented Dec 6, 2015

This PR fixes a major issue for me with caching. Thank you +1 for getting this in soon!

@tomchristie
Copy link
Member

tomchristie commented Dec 7, 2015

No objection from me.

@xordoquy
Copy link
Collaborator

xordoquy commented Dec 7, 2015

Wasn't sure about the str there but I'll trust the tests here.

xordoquy added a commit that referenced this pull request Dec 7, 2015
Fix #3628 by implementing __getnewargs__()
@xordoquy xordoquy merged commit 6bbb289 into encode:master Dec 7, 2015
3 checks passed
@xordoquy
Copy link
Collaborator

xordoquy commented Dec 7, 2015

@Cheglader thanks a lot for the work !!!

@glynjackson
Copy link

glynjackson commented Dec 7, 2015

Thank you @Cheglader

@cosmith
Copy link
Contributor

cosmith commented Dec 17, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants