Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing csrf_token in AdminRenderer post form. #3703

Merged
merged 1 commit into from Jan 19, 2016

Conversation

sniegu
Copy link

@sniegu sniegu commented Dec 4, 2015

CSRF token was missing during object creation through Create form in AdminRenderer. An analogous csrf_token tag in the base browsable API form was introduced in 41182c6.

@xordoquy
Copy link
Collaborator

xordoquy commented Dec 7, 2015

Looks legit for me but I'll ask another to review that as I haven't played with AdminRenderer yet.

@atombrella
Copy link
Contributor

atombrella commented Jan 19, 2016

There are several forms (I grepped for POST-forms) that don't have {% csrf_token %} in them.

xordoquy added a commit that referenced this pull request Jan 19, 2016
Add missing csrf_token in AdminRenderer post form.
@xordoquy xordoquy merged commit e7fbd26 into encode:master Jan 19, 2016
3 checks passed
@xordoquy xordoquy added the Bug label Jan 19, 2016
@xordoquy xordoquy added this to the 3.3.3 Release milestone Jan 19, 2016
@xordoquy
Copy link
Collaborator

xordoquy commented Jan 19, 2016

Thanks, just gave this a try and indeed creation didn't work.

@xordoquy
Copy link
Collaborator

xordoquy commented Jan 19, 2016

@atombrella feel free to open another PR if you can spot missing CSRF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants