Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when setting a removed rest_framework setting for #3644 #3715

Merged
merged 17 commits into from Dec 18, 2015

Conversation

lsanpablo
Copy link
Contributor

@lsanpablo lsanpablo commented Dec 8, 2015

I'm not sure if the error message is detailed enough. Does anyone have a better solution?

@@ -135,6 +135,15 @@
)


SETTINGS_DOC = "http://www.django-rest-framework.org/api-guide/settings/"
Copy link
Collaborator

@xordoquy xordoquy Dec 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's required to make it a setting.

@xordoquy xordoquy modified the milestones: 3.3.2 Release, 3.3.3 Release Dec 14, 2015
@lsanpablo
Copy link
Contributor Author

lsanpablo commented Dec 17, 2015

I agree with you, so I've updated the PR to throw a warning instead.

tomchristie added a commit that referenced this pull request Dec 18, 2015
Raise error when setting a removed rest_framework setting for #3644
@tomchristie tomchristie merged commit 61e7f7b into encode:master Dec 18, 2015
2 checks passed
@tomchristie
Copy link
Member

tomchristie commented Dec 18, 2015

Thanks. That'll do as an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants