Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not HTML-escape help_text in Browsable API forms. #3812

Merged
merged 1 commit into from Jun 2, 2016
Merged

Do not HTML-escape help_text in Browsable API forms. #3812

merged 1 commit into from Jun 2, 2016

Conversation

sinitsynsv
Copy link
Contributor

@sinitsynsv sinitsynsv commented Jan 8, 2016

Some fields in django forms (SetPasswordForm for example, new_password1 field) have html help_text. I think in browsable api help_text must be rendered as is.

@jpadilla
Copy link
Member

jpadilla commented Jan 10, 2016

@sinitsynsv thanks, I see where this would come in handy, although I've never needed to do so. Would love to see what others think.

@tomchristie tomchristie merged commit 94863ee into encode:master Jun 2, 2016
2 checks passed
@tomchristie
Copy link
Member

tomchristie commented Jun 2, 2016

Given the Django docs, this seems valid... https://docs.djangoproject.com/en/1.9/ref/models/fields/#help-text

Note that this value is not HTML-escaped in automatically-generated forms. This lets you include HTML in help_text if you so desire.

Thanks for this @sinitsynsv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants