Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryParameterVersioning does not use DEFAULT_VERSION setting #3833

Merged
merged 1 commit into from Jan 14, 2016

Conversation

bradmontgomery
Copy link
Contributor

@bradmontgomery bradmontgomery commented Jan 14, 2016

QueryParameterVersioning does not fall back to the value used in the DEFAULT_VERSION setting, while other versioning schemes do. This looks like a minor change, and incorporates the self.default_version set in the superclass.

I'll sheepishly admit that I edited this inline without running any tests or anything, so please let me know if this needs more work.

QueryParameterVersioning does not fall back to the value used in the `DEFAULT_VERSION` setting, while other versioning schemes do. This looks like a minor change, and incorporates the `self.default_version` set in the superclass.

I'll sheepishly admit that I edited this inline without running any tests or anything, so please let me know if this needs more work.
@xordoquy xordoquy added this to the 3.3.3 Release milestone Jan 14, 2016
xordoquy added a commit that referenced this issue Jan 14, 2016
QueryParameterVersioning does not use default version
@xordoquy xordoquy merged commit 30ef38c into encode:master Jan 14, 2016
2 checks passed
@xordoquy
Copy link
Collaborator

@xordoquy xordoquy commented Jan 14, 2016

Thanks for fixing this !

@bradmontgomery
Copy link
Contributor Author

@bradmontgomery bradmontgomery commented Jan 14, 2016

You're welcome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants