Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed admin pagination when limit is 0 #3990

Closed
wants to merge 2 commits into from

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Mar 13, 2016

This is an alternative fix #3444.

It is a simpler fix because it simply forces limit to never be 0. By default, if limit is given as 0, then max_limit is used as limit. But this can be changed in a subclass if somebody prefers to use default_limit in such case as well.

This allows one to request a default limit (by not providing limit query parameter) or request a max limit (by providing it with limit=0 as a query parameter).

@tomchristie
Copy link
Member

tomchristie commented Jun 13, 2016

Closed via #4194.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants