Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder initializing the view #4006

Merged
merged 1 commit into from Mar 31, 2016
Merged

Reorder initializing the view #4006

merged 1 commit into from Mar 31, 2016

Conversation

nourspace
Copy link
Contributor

@nourspace nourspace commented Mar 20, 2016

Description

Determining the version and performing content negotiation should be done before ensuring the permission of the request. The reason is that these information can be used in handling the exceptions. For example different versions may return different error scheme. Also, the rendering class can be used to determine how to exception handler response should be rendered.

Determining the version and performing content negotiation should be done before ensuring the permission of the request. The reason is that these information can be used in handling the exceptions. For example different versions may return different error scheme. Also, the rendering class can be used to determine how to exception handler response should be rendered.
@jpadilla
Copy link
Member

jpadilla commented Mar 21, 2016

At a first glance this looks like a small valid enhancement. Anyone else care to review/comment?

@xordoquy
Copy link
Collaborator

xordoquy commented Mar 21, 2016

Seems valid too. Need to think about the side effects related to security of performing computations before permissions checks.

@jpadilla
Copy link
Member

jpadilla commented Mar 21, 2016

Can't think of any atm, since it's just content neg and determining correct version.

@tomchristie
Copy link
Member

tomchristie commented Mar 21, 2016

Consideration: Any point we push permissions later, there are more opportunities to consume resources etc. Having said that I don't think I've any great problems with this change.

@jpadilla
Copy link
Member

jpadilla commented Mar 25, 2016

I can see how useful it might be to have access to request.version when performing authentication, checking permissions and throttling.

@tomchristie
Copy link
Member

tomchristie commented Mar 31, 2016

I'm 👍 with this pull request.

@xordoquy xordoquy added this to the 3.4.0 Release milestone Mar 31, 2016
@xordoquy
Copy link
Collaborator

xordoquy commented Mar 31, 2016

Ok, let's get this moving.

@xordoquy xordoquy merged commit 67ac048 into encode:master Mar 31, 2016
@xordoquy
Copy link
Collaborator

xordoquy commented Mar 31, 2016

nice work, thanks :)

@nourspace
Copy link
Contributor Author

nourspace commented Mar 31, 2016

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants