Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No auth view failing permission should raise 403 #4040

Conversation

johnraz
Copy link
Contributor

@johnraz johnraz commented Apr 7, 2016

Description

A view with no authentication_classes set and that fails a
permission check should raise a 403 with the message from the
failing permission.

Fixes #4039

A view with no `authentication_classes` set and that fails a
permission check should raise a 403 with the message from the
failing permission.
@johnraz johnraz force-pushed the show-permission-message-and-403-when-no-authentication-view branch from be79e2a to 4def193 Compare Apr 7, 2016
@tomchristie tomchristie merged commit 78e4ea0 into encode:master Apr 7, 2016
2 checks passed
@tomchristie
Copy link
Member

tomchristie commented Apr 7, 2016

👍 Yup, good stuff.

@tomchristie tomchristie added the Bug label Apr 7, 2016
@tomchristie tomchristie added this to the 3.3.3 Release milestone Apr 7, 2016
@johnraz
Copy link
Contributor Author

johnraz commented Apr 7, 2016

thx @tomchristie !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants