Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields. Fix None values representation in childs of ListField, DictField. #4118

Merged
merged 1 commit into from May 16, 2016
Merged

Conversation

khasanovbi
Copy link
Contributor

@khasanovbi khasanovbi commented May 14, 2016

None values in childs of DictField, ListField not check in representation.

@codecov-io
Copy link

codecov-io commented May 14, 2016

Current coverage is 91.40%

Merging #4118 into master will not change coverage

@@             master      #4118   diff @@
==========================================
  Files            51         51          
  Lines          5476       5476          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           5005       5005          
  Misses          471        471          
  Partials          0          0          

Powered by Codecov. Last updated by 788603e...b73da53

@tomchristie tomchristie added this to the 3.3.4 Release milestone May 16, 2016
@tomchristie tomchristie merged commit 768ae26 into encode:master May 16, 2016
2 checks passed
@tomchristie
Copy link
Member

tomchristie commented May 16, 2016

Good stuff, thanks! 😄 👍
Could you link to the original issue in this thread, with a refs: #xxx.

@khasanovbi
Copy link
Contributor Author

khasanovbi commented May 17, 2016

@tomchristie Thanks. Sorry, I don't know, that first need to do issue and make pull request without issue. Should I do it now?

@tomchristie
Copy link
Member

tomchristie commented May 17, 2016

Nope not to worry, thought there was an existing issue, but not a problem if there isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants