Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

description.py codes and tests removal #4153

Merged
merged 4 commits into from Jun 1, 2016
Merged

description.py codes and tests removal #4153

merged 4 commits into from Jun 1, 2016

Conversation

auvipy
Copy link
Contributor

@auvipy auvipy commented May 31, 2016

as per comment its and python 2.6 issue

from .description import (
UTF8_TEST_DOCSTRING, ViewWithNonASCIICharactersInDocstring
)

Copy link
Collaborator

@xordoquy xordoquy May 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed for pylint to be happy

@auvipy
Copy link
Contributor Author

auvipy commented May 31, 2016

could delete the description file too?

@codecov-io
Copy link

codecov-io commented May 31, 2016

Current coverage is 91.49%

Merging #4153 into master will not change coverage

@@             master      #4153   diff @@
==========================================
  Files            51         51          
  Lines          5477       5477          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           5011       5011          
  Misses          466        466          
  Partials          0          0          

Powered by Codecov. Last updated by 0777cb7...91bb177

@xordoquy
Copy link
Collaborator

xordoquy commented May 31, 2016

could delete the description file too?

Not sure what you mean. Isn't the file already removed ?

@xordoquy xordoquy added this to the 3.3.4 Release milestone May 31, 2016
@auvipy
Copy link
Contributor Author

auvipy commented Jun 1, 2016

initialy i only deleted the codes now deleted the file too.

@xordoquy xordoquy merged commit 8e2787f into encode:master Jun 1, 2016
2 checks passed
@xordoquy
Copy link
Collaborator

xordoquy commented Jun 1, 2016

Thanks for the work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants