Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

description.py codes and tests removal #4153

Merged
merged 4 commits into from Jun 1, 2016
Merged

description.py codes and tests removal #4153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3db45cb
removed description codes as it seems to be python 2.6 issue
auvipy May 31, 2016
91bb177
removed description tests unicode related functions
auvipy May 31, 2016
4fabdee
fix lint error
auvipy May 31, 2016
eef9485
deleted description.py as unneeded
auvipy Jun 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 0 additions & 25 deletions tests/description.py
View file
Open in desktop

This file was deleted.

16 changes: 1 addition & 15 deletions tests/test_description.py
View file
Open in desktop
Expand Up @@ -3,15 +3,11 @@
from __future__ import unicode_literals

from django.test import TestCase
from django.utils.encoding import python_2_unicode_compatible, smart_text
from django.utils.encoding import python_2_unicode_compatible

from rest_framework.compat import apply_markdown
from rest_framework.views import APIView

from .description import (
UTF8_TEST_DOCSTRING, ViewWithNonASCIICharactersInDocstring
)


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed for pylint to be happy

# We check that docstrings get nicely un-indented.
DESCRIPTION = """an example docstring
Expand Down Expand Up @@ -85,16 +81,6 @@ class MockView(APIView):

self.assertEqual(MockView().get_view_description(), DESCRIPTION)

def test_view_description_supports_unicode(self):
"""
Unicode in docstrings should be respected.
"""

self.assertEqual(
ViewWithNonASCIICharactersInDocstring().get_view_description(),
smart_text(UTF8_TEST_DOCSTRING)
)

def test_view_description_can_be_empty(self):
"""
Ensure that if a view has no docstring,
Expand Down