Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring of must_call_distinct #4215

merged 1 commit into from Jun 23, 2016


Copy link

@tomchristie tomchristie commented Jun 23, 2016

No description provided.

@tomchristie tomchristie added this to the 3.4.0 Release milestone Jun 23, 2016
# Filtering against a many-to-many field requires us to
# call queryset.distinct() in order to avoid duplicate items
# in the resulting queryset.
# We try to avoid this is possible, for performance reasons.
Copy link

@jpadilla jpadilla Jun 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to avoid this if possible, for performance reasons.

Copy link

@codecov-io codecov-io commented Jun 23, 2016

Current coverage is 91.51%

Merging #4215 into master will increase coverage by <.01%

@@             master      #4215   diff @@
  Files            51         51          
  Lines          5537       5538     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
+ Hits           5067       5068     +1   
  Misses          470        470          
  Partials          0          0          

Powered by Codecov. Last updated by 90bb0c5...7c17573

@tomchristie tomchristie merged commit e1f7cc4 into master Jun 23, 2016
3 checks passed
@tomchristie tomchristie deleted the refactor-must-call-distinct branch Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants