Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust uniqueness checks. #4217

Merged
merged 2 commits into from Jun 23, 2016
Merged

Robust uniqueness checks. #4217

merged 2 commits into from Jun 23, 2016

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Jun 23, 2016

Uniqueness checks for an invalid value should quietly pass, as the value does not exist.
This allows other validators to correctly catch the invalid input and return an appropriate error message, rather than resulting in a hard 500 failure.

Closes #3381
Closes #3493

@tomchristie tomchristie added this to the 3.4.0 Release milestone Jun 23, 2016
@codecov-io
Copy link

codecov-io commented Jun 23, 2016

Current coverage is 91.49%

Merging #4217 into master will decrease coverage by 0.01%

@@             master      #4217   diff @@
==========================================
  Files            51         51          
  Lines          5538       5549    +11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           5068       5077     +9   
- Misses          470        472     +2   
  Partials          0          0          

Powered by Codecov. Last updated by a20a756...1761934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants