Add localize keyword argument to DecimalField
#4233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.20%@@ master #4233 diff @@
==========================================
Files 51 52 +1
Lines 5551 5779 +228
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 5082 5271 +189
- Misses 469 508 +39
Partials 0 0
|
| return float(value) | ||
| value = float(value) | ||
| if self.localize: | ||
| value = localize_input(value) |
There was a problem hiding this comment.
Localizing the output doesn't make sense here. FloatField should represent as floats, not as a localized string.
|
In a slight change to my previous comment the actual behavior that we'd want if we do decide to support this should be to only apply localization to numbers which are represented in string format. Changes needed before we could consider this pull request
|
| @@ -923,7 +927,12 @@ def to_internal_value(self, data): | |||
| Validate that the input is a decimal number and return a Decimal | |||
| instance. | |||
| """ | |||
|
|
|||
| if self.localize: | |||
| data = sanitize_separators(data) | |||
There was a problem hiding this comment.
I think this would make slightly more sense after the smart_text/.strip() line below.
tomchristie
changed the title
DecimalField
|
Nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for localized decimal and float fields.
Addresses #2897