lookup_type is deprecated in favor of lookup_expr#4259
Merged
lovelydinosaur merged 1 commit intoencode:masterfrom Jul 13, 2016
Merged
lookup_type is deprecated in favor of lookup_expr#4259lovelydinosaur merged 1 commit intoencode:masterfrom
lovelydinosaur merged 1 commit intoencode:masterfrom
Conversation
assertEquals is deprecated in favor of assertEqual app_name is a required keyword as of Django 1.10
Contributor
Author
|
These are different warnings that I found when running the test suite with the |
Current coverage is 91.23%@@ master #4259 diff @@
==========================================
Files 52 52
Lines 5776 5776
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 5270 5270
Misses 506 506
Partials 0 0
|
Contributor
|
Good stuff, thanks! |
Contributor
|
provided we use py.test, we should just get rid of assert**** and simply use assert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assertEquals is deprecated in favor of assertEqual
app_name is a required keyword as of Django 1.10