Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore meta information for each search field. #4298

Merged
merged 1 commit into from Jul 26, 2016

Conversation

andialbrecht
Copy link
Contributor

@andialbrecht andialbrecht commented Jul 22, 2016

The meta information stored in opts needs to be restored for
each search field. Otherwise it references the wrong model
when an attribute of a related model comes before an attribute
of the original model in search fields. This doesn't apply to
m2m relations since must_call_distinct returns True in that
case.

The meta information stored in opts needs to be restored for
each search field. Otherwise it references the wrong model
when an attribute of a related model comes before an attribute
of the original model in search fields. This doesn't apply to
m2m relations since must_call_distinct returns True in that
case.
@codecov-io
Copy link

codecov-io commented Jul 22, 2016

Current coverage is 91.18% (diff: 100%)

Merging #4298 into master will not change coverage

@@             master      #4298   diff @@
==========================================
  Files            52         52          
  Lines          5776       5776          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           5267       5267          
  Misses          509        509          
  Partials          0          0          

Powered by Codecov. Last update 0f61c9e...c5a2a13

@tomchristie tomchristie added this to the 3.4.1 Release milestone Jul 26, 2016
@tomchristie
Copy link
Member

tomchristie commented Jul 26, 2016

Good catch. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants