Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitter bootstrap minor update #4307

Merged
merged 2 commits into from Jul 26, 2016
Merged

twitter bootstrap minor update #4307

merged 2 commits into from Jul 26, 2016

Conversation

auvipy
Copy link
Contributor

@auvipy auvipy commented Jul 25, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 25, 2016

Current coverage is 91.18% (diff: 100%)

Merging #4307 into master will not change coverage

@@             master      #4307   diff @@
==========================================
  Files            52         52          
  Lines          5776       5776          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           5267       5267          
  Misses          509        509          
  Partials          0          0          

Powered by Codecov. Last update 0f61c9e...a9476b8

@tomchristie
Copy link
Member

tomchristie commented Jul 26, 2016

Looks good. I need to confirm to myself that the minified files are in fact identical to the release versions prior to merging.

@auvipy
Copy link
Contributor Author

auvipy commented Jul 26, 2016

ok. but i copied them from latest release

@tomchristie
Copy link
Member

tomchristie commented Jul 26, 2016

Yes - I need to make sure for myself.
It'd be a security risk if I accepted JS changes without first verifying that the minified files do match up correctly. (Someone else could propose a PR that claimed to be a simple version update, but in fact contained malicious or incorrect minified javascript)

@auvipy
Copy link
Contributor Author

auvipy commented Jul 26, 2016

ohh!! that's ok!!

@kevin-brown
Copy link
Member

kevin-brown commented Jul 26, 2016

Just checked the file contents of both these files and the Bootstrap 3.3.7 dist files, and I grabbed the SHA1 hashes for both.

Bootstrap

CSS: 6527D8BF3E1E9368BAB8C7B60F56BC01FA3AFD68
JS: 430A443D74830FE9BE26EFCA431F448C1B3740F9

These files

CSS: 6527D8BF3E1E9368BAB8C7B60F56BC01FA3AFD68
JS: 430A443D74830FE9BE26EFCA431F448C1B3740F9

It appears that the SHA1 hashes do line up.

@tomchristie tomchristie merged commit b630990 into encode:master Jul 26, 2016
2 checks passed
@tomchristie
Copy link
Member

tomchristie commented Jul 26, 2016

Thanks for the confirmation @kevin-brown!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants