Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urljoin with leading slash remove part of path #4332

Merged
merged 1 commit into from Aug 1, 2016

Conversation

jsurloppe
Copy link
Contributor

@jsurloppe jsurloppe commented Jul 28, 2016

simplify_regex return an url with a leading slash which is interpreted as a root path by urlparse;

>>> urlparse.urljoin("http://localhost:8000/api/", "/foo/")
'http://localhost:8000/foo/'

leads to SchemaGenerator returning a wrong link.

@tomchristie tomchristie added this to the 3.4.2 Release milestone Jul 29, 2016
@tomchristie
Copy link
Member

tomchristie commented Aug 1, 2016

Thanks!

@tomchristie tomchristie merged commit e997713 into encode:master Aug 1, 2016
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants