Skip to content

Descriptive error from FileUploadParser when filename not included.#4340

Merged
lovelydinosaur merged 2 commits intomasterfrom
descriptive-error-when-upload-does-not-include-filename
Aug 1, 2016
Merged

Descriptive error from FileUploadParser when filename not included.#4340
lovelydinosaur merged 2 commits intomasterfrom
descriptive-error-when-upload-does-not-include-filename

Conversation

@lovelydinosaur
Copy link
Contributor

@lovelydinosaur lovelydinosaur commented Aug 1, 2016

If a Content-Disposition including a filename= parameter is not included, then always raise a consistent and informative error. Previous behavior would be:

  • Small files raised an unhelpful and non-descriptive ParseError.
  • Large files succeeded with a randomly generated system filename.

Closes #3610.
Closes #4296.

@lovelydinosaur lovelydinosaur added this to the 3.4.2 Release milestone Aug 1, 2016
@lovelydinosaur lovelydinosaur merged commit 3ef3fee into master Aug 1, 2016
@lovelydinosaur lovelydinosaur deleted the descriptive-error-when-upload-does-not-include-filename branch August 1, 2016 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant