Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of ALLOWED_VERSIONS and no DEFAULT_VERSION #4370

Merged
merged 2 commits into from Aug 10, 2016

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 9, 2016

When only ALLOWED_VERSIONS but no DEFAULT_VERSION is specified, a
version should be enforced. When changing this, no existing tests were
failing. This adds tests for the fixed behavior.

The old behavior can be restored by adding None explicitly to
ALLOWED_VERSIONS.

@tomchristie
Copy link
Member

tomchristie commented Aug 9, 2016

Thanks for this.
Couple of linter failures to be addressed: https://travis-ci.org/tomchristie/django-rest-framework/jobs/150956878

When only `ALLOWED_VERSIONS` but no `DEFAULT_VERSION` is specified, a
version should be enforced.  When changing this, no existing tests were
failing.  This adds tests for the fixed behavior.

The old behavior can be restored by adding `None` explicitly to
`ALLOWED_VERSIONS`.
@blueyed blueyed force-pushed the fix-None-default-version branch from e5aac43 to a69f4bc Compare Aug 9, 2016
@blueyed
Copy link
Contributor Author

blueyed commented Aug 9, 2016

Amended.

@blueyed
Copy link
Contributor Author

blueyed commented Aug 9, 2016

Not amended correctly.
RequestVersionView existed already.. :)

Please squash-merge it into a single commit then, or let me know if I should fix it up / amend it correctly.

@tomchristie tomchristie merged commit 378b04e into encode:master Aug 10, 2016
2 checks passed
@tomchristie
Copy link
Member

tomchristie commented Aug 10, 2016

Yup, looks good - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants