Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include request.FILES items in request.POST #4407

Merged
merged 1 commit into from Aug 15, 2016

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Aug 15, 2016

Multipart uploads are included in the .request.POST attribute, when they should only appear in request.FILES.

Typically this won't be noticed as users of REST framework will be typically working with the unified request.data instead, but it is nonetheless a bug.

@tomchristie tomchristie added this to the 3.4.5 Release milestone Aug 15, 2016
@tomchristie tomchristie changed the title Do not include uploads in request.POST Do not include request.FILES items in request.POST Aug 15, 2016
@tomchristie tomchristie merged commit 101fd29 into master Aug 15, 2016
3 checks passed
@tomchristie tomchristie deleted the do-not-include-files-in-post branch Aug 15, 2016
@tomchristie tomchristie mentioned this pull request Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant