Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace utf8 character ' with its ascii counterpart, makes bdist_rpm happy on CentOS 7 #4412

Merged
merged 1 commit into from Aug 17, 2016

Conversation

nevun
Copy link
Contributor

@nevun nevun commented Aug 17, 2016

Before this:

$ python setup.py bdist_rpm --spec-only
warning: pypandoc module not found, could not convert Markdown to RST
running bdist_rpm
running egg_info
creating djangorestframework.egg-info
writing djangorestframework.egg-info/PKG-INFO
writing top-level names to djangorestframework.egg-info/top_level.txt
writing dependency_links to djangorestframework.egg-info/dependency_links.txt
writing manifest file 'djangorestframework.egg-info/SOURCES.txt'
reading manifest file 'djangorestframework.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
writing manifest file 'djangorestframework.egg-info/SOURCES.txt'
creating dist
Traceback (most recent call last):
  File "setup.py", line 103, in <module>
    'Topic :: Internet :: WWW/HTTP',
  File "/usr/lib64/python2.7/distutils/core.py", line 152, in setup
    dist.run_commands()
  File "/usr/lib64/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/usr/lib64/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/usr/lib/python2.7/site-packages/setuptools/command/bdist_rpm.py", line 28, in run
    _bdist_rpm.run(self)
  File "/usr/lib64/python2.7/distutils/command/bdist_rpm.py", line 296, in run
    self._make_spec_file()),
  File "/usr/lib/python2.7/site-packages/setuptools/command/bdist_rpm.py", line 59, in _make_spec_file
    for line in spec
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 5982: ordinal not in range(128)
$

After:

$ python setup.py bdist_rpm --spec-only
warning: pypandoc module not found, could not convert Markdown to RST
running bdist_rpm
running egg_info
writing djangorestframework.egg-info/PKG-INFO
writing top-level names to djangorestframework.egg-info/top_level.txt
writing dependency_links to djangorestframework.egg-info/dependency_links.txt
reading manifest file 'djangorestframework.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
writing manifest file 'djangorestframework.egg-info/SOURCES.txt'
writing 'dist/djangorestframework.spec'
$

@tomchristie
Copy link
Member

tomchristie commented Aug 17, 2016

Fair enough

@tomchristie tomchristie merged commit 966330a into encode:master Aug 17, 2016
2 checks passed
@tomchristie tomchristie added this to the 3.4.5 Release milestone Aug 17, 2016
@tomchristie tomchristie mentioned this pull request Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants