Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debug error handling #4416

Merged
merged 3 commits into from
Aug 18, 2016
Merged

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Aug 18, 2016

Closes #4409

Ensures that Django's standard exception handling still runs in all uncaught cases, but forces the debug.technical_500_response to render in either plaintext or html, depending on the content negotiation that's taken place.

We have to implement a hack to achieving this, overriding the underlying HTTPRequest.is_ajax() method, however this is probably better than the alternative of reimplementing and keeping up to date with Django's exception handling inside REST framework.

@tomchristie tomchristie added this to the 3.4.5 Release milestone Aug 18, 2016
@tomchristie tomchristie merged commit 382ea77 into master Aug 18, 2016
@tomchristie tomchristie deleted the improve-debug-error-handling branch August 18, 2016 13:42
@tomchristie tomchristie mentioned this pull request Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant