Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add setter to user property on request object #448

Merged
merged 1 commit into from Dec 2, 2012

Conversation

Projects
None yet
2 participants

This change adds a setter to the user property on the request object.

This allows standard django login / logout to be used as discussed here:

https://groups.google.com/d/topic/django-rest-framework/f65BjbQfEjI/discussion

Collaborator

tomchristie commented Nov 27, 2012

Excellent, thanks!
Any chance we could also get the same behaviour on request.auth as part of this pull req?
After that this looks good to go.

@tomchristie tomchristie added a commit that referenced this pull request Dec 2, 2012

@tomchristie tomchristie Merge pull request #448 from mhsparks/master
Add setter to user property on request object
56bb4a5

@tomchristie tomchristie merged commit 56bb4a5 into encode:master Dec 2, 2012

1 check passed

default The Travis build passed
Details

mhsparks commented Dec 2, 2012

Hi Tom - I didn't get chance to do this last week but can add the setter to request.auth this week in a separate pull request if you want?

I didn't have a problem with request.auth but no problem to make the change if required.

Collaborator

tomchristie commented Dec 2, 2012

That'd be great yeah! Thx.

On 2 Dec 2012, at 18:23, mhsparks notifications@github.com wrote:

Hi Tom - I didn't get chance to do this last week but can add the setter to request.auth this week in a separate pull request if you want?

I didn't have a problem with request.auth but no problem to make the change if required.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment