Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing order of django-filter and core api imports in compat #4601

Merged
merged 1 commit into from Oct 21, 2016
Merged

changing order of django-filter and core api imports in compat #4601

merged 1 commit into from Oct 21, 2016

Conversation

lukasz-karolewski
Copy link
Contributor

@lukasz-karolewski lukasz-karolewski commented Oct 20, 2016

Description

when using with django-filter and rest_framework_swagger need to import coreapi before django-filter as django filter tries to load rest_framework.coreapi which is undefined at this point

when using with django-filter and rest_framework_swagger need to import coreapi before django-filter as django filter tries to load rest_framework.coreapi which is undefined at this point
@tomchristie tomchristie added this to the 3.5.1 Release milestone Oct 20, 2016
@rpkilby
Copy link
Member

rpkilby commented Oct 20, 2016

See also carltongibson/django-filter#525, carltongibson/django-filter#526.

Additionally, if django_filters is in your INSTALLED_APPs, try removing it as it isn't necessary.

@tomchristie
Copy link
Member

tomchristie commented Oct 21, 2016

Great stuff, thanks!

@tomchristie tomchristie merged commit 0b346e9 into encode:master Oct 21, 2016
2 of 3 checks passed
@lukasz-karolewski lukasz-karolewski deleted the patch-1 branch Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants