Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few django deprecation warnings #4712

Merged
merged 1 commit into from Nov 29, 2016

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Nov 29, 2016

No description provided.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Great. Thanks!

@xordoquy
Copy link
Collaborator

xordoquy commented Nov 29, 2016

I think those cases could have been spotted if the models were in a models.py file.
The went under Django's check radar because of that.
Still need to figure whether it's ok or not.

@carltongibson
Copy link
Collaborator

carltongibson commented Nov 29, 2016

Still need to figure whether it's ok or not.

I not sure I follow you. 🤔

Docs:

Deprecated since version 1.9: on_delete will become a required argument in Django 2.0. In older versions it defaults to CASCADE.

What's not right? (Or maybe not right?)

@xordoquy
Copy link
Collaborator

xordoquy commented Nov 29, 2016

I though that was required in 1.10.x

@carltongibson
Copy link
Collaborator

carltongibson commented Nov 29, 2016

But we want it right? (Sorry — I think I need one-more-☕️ this morning...)

@tomchristie
Copy link
Member

tomchristie commented Nov 29, 2016

Great stuff!
Not sure I followed @xordoquy totally there, but we can always follow that up separately.

@tomchristie tomchristie merged commit 6498766 into encode:master Nov 29, 2016
3 checks passed
@tomchristie tomchristie added this to the 3.5.4 Release milestone Nov 29, 2016
@rpkilby rpkilby deleted the fix-warnings branch Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants