Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb view name suffix fix #4750

Merged
merged 3 commits into from Dec 20, 2016

Conversation

mmedal
Copy link
Contributor

@mmedal mmedal commented Dec 14, 2016

Description

Fixes: #4729

@tomchristie
Copy link
Member

tomchristie commented Dec 20, 2016

Thanks - to be reviewed.
Any chance you could include screenshots of before and after the fix, together with an example?

@mmedal
Copy link
Contributor Author

mmedal commented Dec 20, 2016

The pull request adds a failing testcase. Below, find examples of restframework's rendered API view based on the ModelViewSet + SimpleRouter configuration in the added testcase.

Before:
restframework_pull

After:
screen shot 2016-12-20 at 1 59 29 pm

@tomchristie
Copy link
Member

tomchristie commented Dec 20, 2016

Looks good - nice work!

@tomchristie tomchristie merged commit 93fe531 into encode:master Dec 20, 2016
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants