Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted testing test asserts to pytest #4949

Merged
merged 2 commits into from Mar 10, 2017
Merged

converted testing test asserts to pytest #4949

merged 2 commits into from Mar 10, 2017

Conversation

auvipy
Copy link
Contributor

@auvipy auvipy commented Mar 9, 2017

No description provided.

@@ -200,8 +200,8 @@ def test_empty_post_uses_default_boolean_value(self):
data=None,
content_type='application/json'
)
self.assertEqual(response.status_code, 200, response.content)
self.assertEqual(response.data, {"flag": True})
Copy link
Contributor Author

@auvipy auvipy Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how this should be formatted?

Copy link
Member

@jpadilla jpadilla Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third arg there is for an optional msg according to docs. I think we can just drop it. I don't think we do that anywhere else.

Copy link
Contributor Author

@auvipy auvipy Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped 3rd arg

@tomchristie tomchristie merged commit baea07c into encode:master Mar 10, 2017
1 check passed
@tomchristie tomchristie added this to the 3.6.2 Release milestone Mar 10, 2017
@auvipy auvipy deleted the test branch Mar 10, 2017
Copy link
Contributor

@adamchainz adamchainz left a comment

@auvipy are you doing this with unittest2pytest ? https://github.com/pytest-dev/unittest2pytest

@auvipy
Copy link
Contributor Author

@auvipy auvipy commented Mar 23, 2017

no but I think I will use it next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants