Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include URL path regexs in API schemas where valid. #5014

Merged
merged 3 commits into from Mar 22, 2017

Conversation

dczech
Copy link

@dczech dczech commented Mar 21, 2017

Description

This is follow-up #5011 and #5006.

Path param based on AutoField is converted into Integer unless view has lookup_value_regex attribute.

Path constraints should be based on view configuration and not on underlying model, but I'm aware that this solution is not optimal.

@tomchristie tomchristie added this to the 3.6.3 Release milestone Mar 22, 2017
@tomchristie tomchristie changed the title Decouple bigautofield Include URL path regexs in API schemas where valid. Mar 22, 2017
@tomchristie tomchristie merged commit 8e9cb1e into encode:master Mar 22, 2017
1 check passed
@tomchristie
Copy link
Member

tomchristie commented Mar 22, 2017

Yup this seems valid - if there's a regex pattern then use a string, with that pattern. 👍

@dczech dczech deleted the feature/decouple-bigautofield branch Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants