Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unique validator for ChoiceField #5026

wants to merge 1 commit into from


Copy link


Fix missing unique validators in ChoiceFields. Closes #5004

Any better place to put this test?

kwargs['choices'] = model_field.choices
return kwargs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Granted this may not be failing any tests, but I'm pretty wary.

Let's make sure that we're testing the case that this describes (a field that would result in adding keyword args that aren't valid on ChoiceField)

Copy link
Member Author

Closing in favor of #5028

@jpadilla jpadilla closed this Mar 28, 2017
@jpadilla jpadilla deleted the issue-5004 branch March 28, 2017 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants