Fix unique validator for ChoiceField #5026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tomchristie
reviewed
Mar 27, 2017
| kwargs['choices'] = model_field.choices | ||
| return kwargs |
There was a problem hiding this comment.
Granted this may not be failing any tests, but I'm pretty wary.
Let's make sure that we're testing the case that this describes (a field that would result in adding keyword args that aren't valid on ChoiceField)
|
Closing in favor of #5028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Fix missing unique validators in ChoiceFields. Closes #5004
Any better place to put this test?