Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaGenerator: Avoid crashing with pagesizeless paginators #5086

Merged
merged 1 commit into from Apr 27, 2017

Conversation

akx
Copy link
Contributor

@akx akx commented Apr 19, 2017

When using master (bd768d6) with LimitOffsetPagination, SchemaGenerator crashes:

  File "rest_framework/schemas.py", line 607, in get_pagination_fields
    if not pagination or not pagination.page_size:
AttributeError: type object 'LimitOffsetPagination' has no attribute 'page_size'

This is related to #4998.

@tomchristie
Copy link
Member

tomchristie commented Apr 27, 2017

Thank you!

@tomchristie tomchristie added this to the 3.6.3 Release milestone Apr 27, 2017
@tomchristie tomchristie merged commit 5e5fd67 into encode:master Apr 27, 2017
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants