Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If pagination class, include the schema generation #5161

Merged
merged 1 commit into from May 22, 2017

Conversation

matteius
Copy link
Contributor

@matteius matteius commented May 22, 2017

Refs #5144

Description

This fixes a bug that was introduced in commit: 6ad0be4#diff-eae91da078f88bdb425b240be0ee5487
Then was mutated by this followup commit: 72da733

I change the logic back to not consider the page_size attribute at all as it is irrelevant for generating the schema -- should have nothing to do with the actual page size.

@khakulov
Copy link
Contributor

You can't just remove page_size check. It is breaking change. So people need to set DEFAULT_PAGINATION_CLASS=None.

Better to check api_settings.PAGE_SIZE is not None

@xordoquy
Copy link
Collaborator

@khakulov yes, people may need to set DEFAULT_PAGINATION_CLASS=None.
This being said, it would be nice for the documentation to mention that in the schema part if it's not already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants