Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure max_length is in FileField kwargs #5186

Merged
merged 2 commits into from May 29, 2017

Conversation

dryice
Copy link
Contributor

@dryice dryice commented May 27, 2017

Note: Before submitting this pull request, please review our contributing guidelines.

Description

Make sure max_length is passed to field_kwargs for FileField and ImageField, so that it could be check against at https://github.com/encode/django-rest-framework/blob/master/rest_framework/fields.py#L1452

@jpadilla
Copy link
Member

jpadilla commented May 27, 2017

@dryice Thanks for this! We should probably add a simple test(probably somewhere around here) to make sure we've got this covered.

@dryice
Copy link
Contributor Author

dryice commented May 29, 2017

Thanks for the quick approval @jpadilla ! Just added a test.

@xordoquy xordoquy added this to the 3.6.4 Release milestone May 29, 2017
@xordoquy
Copy link
Collaborator

xordoquy commented May 29, 2017

Nice job !

@xordoquy xordoquy merged commit 6c7a7cc into encode:master May 29, 2017
1 check passed
@dryice
Copy link
Contributor Author

dryice commented May 29, 2017

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants