Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote nested API parameters in api.js #5214

Merged
merged 1 commit into from Jun 13, 2017
Merged

Conversation

dmkoch
Copy link
Contributor

@dmkoch dmkoch commented Jun 13, 2017

I sometimes have parameter names with a period (.) in them, to represent nested objects, e.g. containerobj.inner_param. The Javascript was throwing an error in the browsable API when interacting with those parameters.

Note: Before submitting this pull request, please review our contributing guidelines.

Description

Please describe your pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. When linking to an issue, please use refs #... in the description of the pull request.

I sometimes have parameter names with a period (.) in them, to represent nested objects, e.g. containerobj.inner_param. The Javascript was throwing an error in the browsable API when interacting with those parameters.
@jpadilla jpadilla added this to the 3.6.4 Release milestone Jun 13, 2017
@jpadilla
Copy link
Member

jpadilla commented Jun 13, 2017

@dmkoch definitely valid, thanks!

@jpadilla jpadilla merged commit 0e106c1 into encode:master Jun 13, 2017
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants