Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests on Windows. Added unicode support to SlugField #5231

Merged

Conversation

dmmatson
Copy link
Contributor

@dmmatson dmmatson commented Jun 24, 2017

Description

This implements the allow_unicode argument for SlugField per #5223, to align with the behavior of the Django SlugField (https://docs.djangoproject.com/en/1.11/ref/models/fields/#slugfield).

Also fixing a couple tests that don't pass on Windows because tempfile.NamedTemporaryFile cannot be opened more than once simultaneously. If this change isn't appropriate for this pull request, let me know and I'll pull it.

Closes #5223

@tomchristie
Copy link
Member

tomchristie commented Jul 7, 2017

Looks great, nice work!

@tomchristie tomchristie merged commit 3dab905 into encode:master Jul 7, 2017
1 check passed
@tomchristie tomchristie added this to the 3.6.4 Release milestone Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants