Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 3288 #5313

Merged
merged 3 commits into from Aug 7, 2017
Merged

Revert 3288 #5313

merged 3 commits into from Aug 7, 2017

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Aug 7, 2017

Reverting #3288 solves issues demonstrated in #5087 and #2555. Accessing a field/serializer root before the parent is bound resulted in the incorrect object being cached. My thoughts on this are that the caching benefits have nominal performance improvements and isn't really worth the incorrect behavior.

@tomchristie tomchristie merged commit 26ebb88 into encode:master Aug 7, 2017
1 check passed
@tomchristie
Copy link
Member

tomchristie commented Aug 7, 2017

Thanks @rpkilby!

@tomchristie tomchristie added this to the 3.6.4 Release milestone Aug 7, 2017
@tomchristie tomchristie added the Bug label Aug 7, 2017
@rpkilby rpkilby deleted the revert-3288 branch Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants