Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModelSerializer custom named fields with source on model #5388

Merged
merged 3 commits into from Sep 4, 2017

Conversation

jonsongoffwhite
Copy link
Contributor

@jonsongoffwhite jonsongoffwhite commented Sep 4, 2017

Description

Fixes #5389

Includes a test that fails on master, passes before #5138, and now passes with included fix.

@jonsongoffwhite jonsongoffwhite changed the title Fix/named source Fix ModelSerializer custom named fields with source on model Sep 4, 2017
@carltongibson
Copy link
Collaborator

carltongibson commented Sep 4, 2017

Hi @JHG14 Could I trouble you for a description please? Thanks!

Copy link
Collaborator

@carltongibson carltongibson left a comment

Yep. Looks good. Thank you.

Copy link
Collaborator

@carltongibson carltongibson left a comment

@jonsongoffwhite
Copy link
Contributor Author

jonsongoffwhite commented Sep 4, 2017

@carltongibson Should be good now!

@carltongibson carltongibson added this to the 3.6.5 Release milestone Sep 4, 2017
@carltongibson carltongibson merged commit 71ad99e into encode:master Sep 4, 2017
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants