Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test matrix: Add Django 2.0, drop 1.8 #5457

Merged
merged 2 commits into from Sep 27, 2017

Conversation

carltongibson
Copy link
Collaborator

@carltongibson carltongibson commented Sep 27, 2017

Replaces #5442, focusing just on the text matrix.

Updated requirements
@carltongibson carltongibson added this to the 3.7.0 Release milestone Sep 27, 2017
@carltongibson carltongibson requested a review from xordoquy Sep 27, 2017
@carltongibson carltongibson merged commit 2969040 into encode:master Sep 27, 2017
1 check passed
@carltongibson carltongibson deleted the 37/update-tox branch Sep 27, 2017
@tomchristie
Copy link
Member

tomchristie commented Sep 27, 2017

Unless there's a clear benefit I see no need to drop 1.9 for this release.
Granted it's EOL, but there's different concerns w/ Django's policy vs ours.
In contrast - we do have cause to drop 1.8 for this release since it makes one of our issues easier to close off.

@tomchristie
Copy link
Member

tomchristie commented Sep 27, 2017

In short: it doesn't cost us anything to continue to support 1.9 for now, but it does cost us to continue to support 1.8. That's our guiding line here.

@xordoquy
Copy link
Collaborator

xordoquy commented Sep 27, 2017

provided that we'll drop it whenever it'll become a pain point what's the point of keeping it ?

@tomchristie
Copy link
Member

tomchristie commented Sep 27, 2017

what's the point of keeping it ?

I'm not that fussed either way, but...

In order to better support teams who started their project in the first half of 2016, who'd like to stay up to date with the latest version of REST framework, and don't have any pressing reasons to upgrade from Django 1.9. (Despite the formal EOL)

@tomchristie
Copy link
Member

tomchristie commented Sep 27, 2017

@xordoquy @carltongibson - Happy to defer to your judgement here, tho. Go for it! 😄

@carltongibson
Copy link
Collaborator Author

carltongibson commented Sep 27, 2017

OK, cool.

Just for anyone reading this, my views are:

  1. Formal EOL is a pressing reason to upgrade. This is simply from the security aspect. It's really not OK to be using EOL software.
  2. The non-LTS versions are explicitly for people who are in a position to keep up. Others should use LTS.

For both these reasons I'm for keeping the matrix rolling forwards — otherwise we send the wrong message to users.

But also, it does make our job easier: #5458

carltongibson added a commit that referenced this pull request Sep 27, 2017
Remove Django 1.8 & 1.9 from README and setup.py
carltongibson added a commit that referenced this pull request Sep 27, 2017
Remove Django 1.8 & 1.9 from README and setup.py
@rpkilby
Copy link
Member

rpkilby commented Sep 27, 2017

One minor reason to drop 1.9 is that it reduces the total build time/saves trees.

carltongibson added a commit that referenced this pull request Sep 28, 2017
Remove Django 1.8 & 1.9 from README and setup.py
carltongibson added a commit that referenced this pull request Oct 5, 2017
Remove Django 1.8 & 1.9 from README and setup.py
carltongibson added a commit that referenced this pull request Oct 5, 2017
Remove Django 1.8 & 1.9 from README and setup.py
carltongibson pushed a commit that referenced this pull request Oct 6, 2017
* Set version number for 3.7.0 release

* Rename release notes section

Moved issue links to top for easier access.
(Can move back later)

* Add release note for #5273

* Add release note for #5440

* Add release note for #5265

Strict JSON handling

* Add release note for #5250

* Add release notes for #5170

* Add release notes for #5443

* Add release notes for #5448

* Add release notes for #5452

* Add release not for #5342

* Add release notes for 5454

* Add release notes for #5058 & #5457

Remove Django 1.8 & 1.9 from README and setup.py

* Release notes for merged 3.6.5 milestone tickets

Tickets migrated to 3.7.0 milestone.

* Add release notes for #5469

* Add release notes from AM 2ndOct

* Add final changes to the release notes.

* Add date and milestone link

Move issue links back to bottom.

* Update translations from transifex

* Begin releae anouncement

* Add release note for #5482

* 3.7 release announcement & related docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants