Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding examples and documentation for caching #5514

Merged
merged 1 commit into from Oct 20, 2017

Conversation

pratyushmittal
Copy link
Contributor

@pratyushmittal pratyushmittal commented Oct 19, 2017

The default caching system of Django works very well with DRF. However, the usage is not very easy to understand for class based views as the documentation is spread across pages. This pull-request provides example code on how to use caching with apiviews and viewsets.

(Edit: @carltongibson: Closes #370)

The default caching system of Django works very well with DRF. However, the usage is not very easy to understand for class based views as the documentation is spread across pages. This pull-request provides example code on how to use caching with apiviews and viewsets.
Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I will give it a proper review tomorrow AM.

(I think there may be some long standing issues related to this... I need to have a look)

@carltongibson carltongibson added this to the 3.7.2 milestone Oct 20, 2017
@carltongibson
Copy link
Collaborator

@pratyushmittal It turns out the issue was #370 — our very oldest open issue! So you get a big cheer for that: 🎉💃🏼🎇

This is a good beginning to a caching page. No doubt people will follow-up with more but this is what we need to get started.

Awesome! Thank you!

@carltongibson carltongibson merged commit f87699e into encode:master Oct 20, 2017
@pratyushmittal
Copy link
Contributor Author

Thanks a lot @carltongibson for a super quick review, merge and appreciation :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants