Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ImageField validation pattern #5539

Merged
merged 1 commit into from Nov 6, 2017
Merged

Change ImageField validation pattern #5539

merged 1 commit into from Nov 6, 2017

Conversation

sazarkin
Copy link
Contributor

@sazarkin sazarkin commented Oct 27, 2017

Related to #5534
Well it is fixes the issue. But I don't know how to test this.
Probably there is a different way to resolve this problem.

@carltongibson
Copy link
Collaborator

carltongibson commented Oct 30, 2017

@sazarkin OK. Thanks for this.

I need to have a think about whether this is the right approach. (Given the comment, it could well be.)

Copy link
Collaborator

@carltongibson carltongibson left a comment

This looks good: the move to clean from to_python will just apply the validator (for all versions for which it is present)

I can't see a problem there. (Since we've stubbed the testing I don't see what else we can reasonably do.)

Thanks!

@carltongibson carltongibson added this to the 3.7.2 milestone Nov 6, 2017
@carltongibson carltongibson merged commit d49d796 into encode:master Nov 6, 2017
1 check passed
@carltongibson carltongibson mentioned this pull request Nov 6, 2017
6 tasks
@suparnaj3
Copy link

suparnaj3 commented Dec 21, 2019

The Django extension validation fails when there's no extension in the name. What you guys think about considering content type instead of name for validation?

@carltongibson
Copy link
Collaborator

carltongibson commented Jan 21, 2020

HI @suparnaj3. Sounds good in theory but it's making it work, and tests. (If it's something you want to put a proof-of-concept together for, I'm sure we'd love to have a look 🙂)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants