Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Location header is strictly a 'str', not subclass. #5544

Merged
merged 1 commit into from Oct 30, 2017

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Oct 30, 2017

Closes #5541

@tomchristie tomchristie added this to the 3.7.2 milestone Oct 30, 2017
@tomchristie tomchristie merged commit 2b6245d into master Oct 30, 2017
2 checks passed
@tomchristie tomchristie deleted the strict-str-header branch Oct 30, 2017
@@ -27,7 +27,7 @@ def perform_create(self, serializer):

def get_success_headers(self, data):
try:
return {'Location': data[api_settings.URL_FIELD_NAME]}
return {'Location': str(data[api_settings.URL_FIELD_NAME])}
Copy link

@canni canni Oct 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not six.text_type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants